Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-4191] Release pipeline fixed #11

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[DPE-4191] Release pipeline fixed #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116087f
Release pipeline fixed
juditnovak Apr 23, 2024
578c618
data_interfaces v34
juditnovak Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ jobs:
matrix:
path:
- .
# - tests/integration/app-charm
Comment on lines 67 to -70
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: matrix can be removed entirely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm wondering if for traefik integration tests it may come handy to have a little test charm. (As we won't be able to test against the real, cross-model system in the tests).

If I won't need it still, I'll remove it then!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refeence added to the [DPE-3954] Final cleanup ticket

name: Build charm
uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@v11.0.1
with:
Expand All @@ -86,6 +85,3 @@ jobs:
artifact-prefix: ${{ needs.build.outputs.artifact-prefix }}
cloud: lxd
juju-agent-version: 3.1.6
_beta_allure_report: false
permissions:
contents: write # Needed for Allure Report beta
2 changes: 0 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ jobs:
name: Tests
uses: ./.github/workflows/ci.yaml
secrets: inherit
permissions:
actions: write # Needed to manage GitHub Actions cache

build:
name: Build charm
Expand Down