Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charm): make collect-status a LifeCycleEvent to avoid logging it #1080

Merged
merged 4 commits into from
Jan 30, 2024
Merged

fix(charm): make collect-status a LifeCycleEvent to avoid logging it #1080

merged 4 commits into from
Jan 30, 2024

Conversation

PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Nov 23, 2023 •
edited by benhoyt
Loading

Make CollectStatusEvent inherit from LifecycleEvent to avoid logging it.

Fixes #1079

@PietroPasotti PietroPasotti mentioned this pull request Nov 23, 2023
Closed
benhoyt
benhoyt requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Couple of minor comments / requested changes.

ops/log.py Outdated Show resolved Hide resolved
test/charms/test_main/src/charm.py Outdated Show resolved Hide resolved
ops/framework.py Outdated Show resolved Hide resolved
tonyandrewmeyer
tonyandrewmeyer approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comments from Ben (and Pietro's original concerns) about the volume of low-value records being sent to Juju. Otherwise seems good to me!

@benhoyt benhoyt changed the title make collect-status a lifecycle event fix(charm): make collect-status a LifeCycleEvent to avoid logging it Jan 30, 2024
@benhoyt benhoyt merged commit d49fa98 into canonical:main Jan 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collect_*_status and lifecycle events
3 participants
@PietroPasotti @tonyandrewmeyer @benhoyt