docs: add a section to HACKING.md on PR titles (commit messages to main) #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
reviewed
Jun 7, 2024
benhoyt
approved these changes
Jun 7, 2024
dimaqq
approved these changes
Jun 10, 2024
dimaqq
reviewed
Jun 14, 2024
benhoyt
changed the title
|
@tonyandrewmeyer Is this good to merge? |
|
@IronCore864 are you ok with this as well? We've got two approvals (plus the implicit one from me as author) but it would be nice to have the whole team approve pre-merging since this is about team process rather than a specific feature. |
IronCore864
approved these changes
Jun 14, 2024
I'm completely OK with this. I like it that we keep "refactor", and only use scope for harness. |
dimaqq
added a commit
that referenced
this pull request
Jun 20, 2024
As documented in #1252 - types taken from the doc PR - scopes were scraped from project PR history
tonyandrewmeyer
added a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Jun 26, 2024
…in) (canonical#1252) Explain that we use conventional commits, and list the types and scopes that we're starting with.
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Jun 26, 2024
As documented in canonical#1252 - types taken from the doc PR - scopes were scraped from project PR history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain that we use conventional commits, and list the types and scopes that we're starting with.