Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: validate PR title against conventional commit rules #1262

Merged
merged 4 commits into from
Jun 20, 2024
Merged

ci: validate PR title against conventional commit rules #1262

merged 4 commits into from
Jun 20, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Jun 14, 2024

As documented in #1252

  • types taken from the doc PR
  • scopes were scraped from project PR history

benhoyt
benhoyt requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, thanks. Couple of changes suggested to the lists, based on #1252.

.github/workflows/semantic-pr-check.yaml Outdated Show resolved Hide resolved
.github/workflows/semantic-pr-check.yaml Outdated Show resolved Hide resolved
@dimaqq dimaqq force-pushed the ci-enfroce-conventional-commit-prs branch from 63d14d8 to 0b00e4c Compare June 18, 2024 03:41
@dimaqq
Copy link
Contributor Author

dimaqq commented Jun 18, 2024

Validated that this works: dimaqq#28

@dimaqq dimaqq requested a review from benhoyt June 19, 2024 08:49
benhoyt
benhoyt approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tonyandrewmeyer
tonyandrewmeyer approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks good to me. I did not look at the upstream source to verify that it's not doing anything bad (particularly with the token we are providing) - I'm not super well placed to do that in JS. The upstream repo seems fairly healthy, which is a positive indicator.

@dimaqq dimaqq merged commit 89ea7f4 into canonical:main Jun 20, 2024
26 checks passed
tonyandrewmeyer pushed a commit to tonyandrewmeyer/operator that referenced this pull request Jun 26, 2024
@dimaqq @tonyandrewmeyer
ci: validate PR title against conventional commit rules (canonical#1262)
dce4a0d 
As documented in canonical#1252

- types taken from the doc PR
- scopes were scraped from project PR history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@benhoyt benhoyt benhoyt approved these changes

@IronCore864 IronCore864 Awaiting requested review from IronCore864

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimaqq @tonyandrewmeyer @benhoyt