Add config alias to CharmBase #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed on [Discourse][], using `self.model.config` can cause the charm author to believe they are accessing the model-level config. It's also extra typing for something that is going to be frequently accessed, so like the other frequently accessed attributes like `self.app`, `self.unit`, etc, a `self.config` alias seems easier and less likely to lead to confusion. [Discourse]: https://discourse.juju.is/t/first-steps-with-the-operator-framework/3006/12
chipaca
approved these changes
Oct 1, 2020
justinmclark
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discourse, using
self.model.configcan cause the charm author to believe they are accessing the model-level config. It's also extra typing for something that is going to be frequently accessed, so like the other frequently accessed attributes likeself.app,self.unit, etc, aself.configalias seems easier and less likely to lead to confusion.