-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing charm.py #791
Typing charm.py #791
Conversation
This looks like it maybe was built on top of the relation keys typing PR. Could you rebase it so this only has the charm.py typing commits? |
5523889
to
cf9a627
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good, just a few relatively minor things.
Typed ops/charm.py
Minor changes to framework.py and vendor/yaml.py types as well.
Checklist
QA steps
tox -e static
Changelog
charm.py