[JUJU-1887] Adds kill delay duration for service shutdown. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
reviewed
Feb 8, 2023
tlm
force-pushed
the
kill-delay
branch
3 times, most recently
from
ce79b8e
to
899dd30
Compare
benhoyt
reviewed
Feb 9, 2023
benhoyt
approved these changes
Feb 9, 2023
|
Just passing by to say that's super critical for data platform deployments and we are looking forward to it. 😬 |
delgod
approved these changes
Feb 14, 2023
niemeyer
requested changes
Feb 14, 2023
tlm
force-pushed
the
kill-delay
branch
3 times, most recently
from
6bdd2d5
to
2424889
Compare
niemeyer
requested changes
Mar 1, 2023
| shortFailWait = 200 * time.Millisecond | ||
| shortOkayDelay = 50 * time.Millisecond | ||
| shortKillDelay = 100 * time.Millisecond | ||
| shortFailDelay = 100 * time.Millisecond |
There was a problem hiding this comment.
It's because the original shortFailWait included both the time from first SIGTERM to SIGKILL and the second wait after that (100+100=200). Now the code is such that "fail delay" only includes that second part (which I think is a bit clearer in any case). So the total wait time here wasn't changed.
- This change adds a new key to the Pebble service plan spec called kill-delay. This allows the author of a service definition to control the amount of time Pebble allows before sending SIGTERM and SIGKILL to a process. - This change also increases the default duration afforded to pebble for kill-delay from 5s to 25s.
niemeyer
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new key to the Pebble service plan spec called kill-delay. This allows the author of a service definition to control the amount of time Pebble allows before sending SIGTERM and SIGKILL to a process.
This change also increases the default duration afforded to pebble for kill-delay from 5s to 25s.