Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firmware metadata load support #207

Closed
wants to merge 1 commit into from
Closed

Conversation

flotter
Copy link
Contributor

@flotter flotter commented Mar 27, 2023

Firmware metadata are accessible in the root filesystem of the running firmware at the following location, encoded as JSON:

/termus/meta/termus.json

Information obtained from this file represents build-time attributes of the firmware that is required by the firmware state manager.

Revision is taken verbatim from the snapd project while the firmware info logic takes inspiration from the snap info code.

@anpep anpep requested review from mvo5, anpep and benhoyt March 27, 2023 10:18
@flotter flotter force-pushed the fwinfo branch 2 times, most recently from 86e992b to bfc0cab Compare March 27, 2023 10:25
Copy link
Collaborator

@anpep anpep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nitpicking :) on a good PR 👍

internal/firmware/info.go Outdated Show resolved Hide resolved
internal/firmware/info_fw.go Outdated Show resolved Hide resolved
internal/firmware/info_fw.go Outdated Show resolved Hide resolved
internal/firmware/info_test.go Outdated Show resolved Hide resolved
internal/firmware/info_test.go Outdated Show resolved Hide resolved
internal/firmware/info_test.go Outdated Show resolved Hide resolved
internal/firmware/info_test.go Outdated Show resolved Hide resolved
internal/firmware/info_test.go Outdated Show resolved Hide resolved
@flotter flotter force-pushed the fwinfo branch 3 times, most recently from 3a896dd to a13be4a Compare March 27, 2023 13:42
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, but looks good to me.

internal/firmware/revision.go Outdated Show resolved Hide resolved
internal/firmware/export_test.go Outdated Show resolved Hide resolved
internal/firmware/export_test.go Outdated Show resolved Hide resolved
internal/firmware/info_store.go Outdated Show resolved Hide resolved
internal/firmware/info.go Show resolved Hide resolved
Firmware metadata are accessible in the root filesystem of the running
firmware at the following location, encoded as JSON:

/termus/meta/termus.json

Information obtained from this file represents build-time attributes
of the firmware that is required by the firmware state manager.

Revision is taken verbatim from the snapd project while the firmware
info logic takes inspiration from the snap info code.
internal/firmware/revision.go Show resolved Hide resolved
internal/firmware/revision.go Show resolved Hide resolved
internal/firmware/revision_test.go Show resolved Hide resolved
internal/firmware/info_test.go Show resolved Hide resolved
internal/firmware/info.go Show resolved Hide resolved
internal/firmware/revision.go Show resolved Hide resolved
internal/firmware/revision.go Show resolved Hide resolved
internal/firmware/revision.go Show resolved Hide resolved
internal/firmware/revision.go Show resolved Hide resolved
internal/firmware/revision.go Show resolved Hide resolved
@flotter
Copy link
Contributor Author

flotter commented May 25, 2023

@hpidcock Thanks for taking the time to review. I will resolve and let you know. This PR is scheduled to migrate to the spinoff Pebble repo, which we are in the process of finalising. I will pause work here until I can migrate it over, and then update this PR. I hope this is OK with you.

@flotter flotter added the Blocked Waiting for something external label May 25, 2023
@niemeyer
Copy link
Contributor

Per our agreements, closing as this is moving elsewhere now.

@niemeyer niemeyer closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Waiting for something external
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants