-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firmware metadata load support #207
Conversation
86e992b
to
bfc0cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of nitpicking :) on a good PR 👍
3a896dd
to
a13be4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments, but looks good to me.
Firmware metadata are accessible in the root filesystem of the running firmware at the following location, encoded as JSON: /termus/meta/termus.json Information obtained from this file represents build-time attributes of the firmware that is required by the firmware state manager. Revision is taken verbatim from the snapd project while the firmware info logic takes inspiration from the snap info code.
@hpidcock Thanks for taking the time to review. I will resolve and let you know. This PR is scheduled to migrate to the spinoff Pebble repo, which we are in the process of finalising. I will pause work here until I can migrate it over, and then update this PR. I hope this is OK with you. |
Per our agreements, closing as this is moving elsewhere now. |
Firmware metadata are accessible in the root filesystem of the running firmware at the following location, encoded as JSON:
/termus/meta/termus.json
Information obtained from this file represents build-time attributes of the firmware that is required by the firmware state manager.
Revision is taken verbatim from the snapd project while the firmware info logic takes inspiration from the snap info code.