Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sane_block_devices when looking for dasds #117

Merged
merged 2 commits into from
May 17, 2022
Merged

use sane_block_devices when looking for dasds #117

merged 2 commits into from
May 17, 2022

Conversation

mwhudson
Copy link
Collaborator

dbungert
dbungert reviewed May 16, 2022
View reviewed changes
Copy link
Collaborator

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the list_devices() call in bcache.probe() also vulnerable?

@mwhudson
Copy link
Collaborator Author

Is the list_devices() call in bcache.probe() also vulnerable?

I don't think so because I can't imagine a device that would have ID_FS_TYPE=bcache but somehow not have MAJOR but I guess there's no harm in using it there too.

@dbungert
Copy link
Collaborator

Is the list_devices() call in bcache.probe() also vulnerable?

I don't think so because I can't imagine a device that would have ID_FS_TYPE=bcache but somehow not have MAJOR but I guess there's no harm in using it there too.

I suspect you would have previously said the same about dasd 😀
Thanks!

@mwhudson mwhudson merged commit 0f1233a into canonical:master May 17, 2022
@dbungert dbungert mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbungert dbungert dbungert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwhudson @dbungert