Add support for TLS client cert/key in tls_config
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
requested review from
sed-i,
Abuelodelanada,
rbarry82,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
sed-i
reviewed
Jan 30, 2023
simondeziel
requested review from
sed-i
and removed request for
Abuelodelanada,
simskij,
dstathis,
PietroPasotti,
lucabello and
rbarry82
simondeziel
force-pushed
the
tls-cert-key
branch
3 times, most recently
from
b807548
to
94fc5ed
Compare
sed-i
approved these changes
Feb 1, 2023
|
@rbarry82 please let me know if you'd like me to make any changes, thanks! |
rbarry82
approved these changes
Feb 13, 2023
simondeziel
force-pushed
the
tls-cert-key
branch
from
e21220e
to
ebe6aa9
Compare
simondeziel
force-pushed
the
tls-cert-key
branch
from
4d4f40b
to
ebe6aa9
Compare
sed-i
reviewed
Apr 11, 2023
simondeziel
force-pushed
the
tls-cert-key
branch
2 times, most recently
from
4aff893
to
4711109
Compare
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…uested Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
tls-cert-key
branch
2 times, most recently
from
0a6d244
to
3622e98
Compare
|
@sed-i I've integrated your feedback, please let me know if I missed something! Thanks! |
|
Looks great, thank you! |
|
@simondeziel the CI was fixed. Do you mind pushing an empty commit to retrigger CI? |
simondeziel
force-pushed
the
tls-cert-key
branch
from
a1845d1
to
285162f
Compare
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
force-pushed
the
tls-cert-key
branch
from
285162f
to
50529f8
Compare
|
@sed-i it seems that "PR / Quality Checks / Integration Tests" is still waiting on something. |
These actually passed, from the looks of it. GH just isn't reporting it. This works in manual testing. Anything still pending @simondeziel ? |
|
@rbarry82 nope, all done on my side, thanks! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The prometheus2 machine charm supports injecting a TLS client cert/key to use when scraping a given target.
This PR adds support for TLS client cert/key (
cert_file/key_file) to thetls_configkey.Note: the LXD charm uses that feature when related with
prometheus2and we'd like to keep using it when related withprometheus-k8s.Release Notes
Support TLS client authentication when scraping metrics.