Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TLS if certificate is available #496

Merged
merged 18 commits into from
Jul 24, 2023
Merged

Enable TLS if certificate is available #496

merged 18 commits into from
Jul 24, 2023

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jul 17, 2023 •
edited
Loading

Issue

Need to run prometheus with TLS.

Tracking issue: canonical/cos-lite-bundle#75

Solution

Update configs with certs data.

TODO:

  • self-scrape (_default_job)
  • prometheus_server.py
  • self-scrape via relation (self.self_scraping_job)
  • remote-write
  • grafana source
  • web_external_url
  • tests

Context

Testing Instructions

TBD.

Release Notes

Enable TLS if certificate is available.

@sed-i sed-i mentioned this pull request Jul 17, 2023
Open
@sed-i sed-i marked this pull request as ready for review July 20, 2023 21:12
@lucabello
Copy link
Contributor

Just pointing out that integration tests are passing, though this webpage says some checks haven't completed yet

@sed-i sed-i mentioned this pull request Jul 23, 2023
Merged
lucabello
lucabello approved these changes Jul 24, 2023
View reviewed changes
metadata.yaml Outdated Show resolved Hide resolved
@sed-i
Copy link
Contributor Author

sed-i commented Jul 24, 2023

CI is green, but not reflected on the PR page here. Merging.

@sed-i sed-i merged commit bad3697 into main Jul 24, 2023
12 checks passed
@sed-i sed-i deleted the feature/tls branch July 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucabello lucabello lucabello approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sed-i @lucabello