This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Fix code coverage #187
Merged
Fix code coverage #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuBordere
force-pushed
the
fix_coverage
branch
2 times, most recently
from
edb1cab
to
fd7ee3e
Compare
MathieuBordere
force-pushed
the
fix_coverage
branch
from
fd7ee3e
to
0b710ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__gcov_flush()is normally called by the exit handlers that are called in response toexit,exithowever was causing hangs on arm64 and ppc64le, and was replaced with_exitin munit. Because_exitdoesn't call exit handlers, we need to call__gcov_flush()ourselves when compiling with code coverage enabled.edit: Will just double-check if ASAN still works as expected with theASAN still worksexit-->_exitchange