This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
uv_append: Check if segment wasn't closed in write request cb #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
|
Thanks for this! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an instance of #245.
The callback of the append request being fired by the write completing, could trigger a new append that finalized the segment that was just written to, leading to the assertion being triggered. I was able to reproduce this in a couple of longer running tests, with this fix, the issue disappeared.
Signed-off-by: Mathieu Borderé mathieu.bordere@canonical.com