fix(spread): tests must also use newer Chisel #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
linostar
requested changes
Jan 17, 2024
tigarmo
reviewed
Jan 17, 2024
|
Seems to be good now. The test failed again, but this time due to a timeout. I've re-triggered anyway |
tigarmo
approved these changes
Jan 17, 2024
tigarmo
pushed a commit
that referenced
this pull request
Jan 25, 2024
tigarmo
pushed a commit
that referenced
this pull request
Jan 25, 2024
tigarmo
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After canonical/chisel-releases#78, the spread tests are now also failing because the building of the Chisel tool was still being done manually, from a hardcoded commit.
This PR changes the failing spread tasks such that Chisel is also installed from the snap store.
Fixes the tests for #455 (comment).