Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ROCK automations for building and pushing ROCKs #58

Closed
kimwnasptd opened this issue Nov 20, 2023 · 0 comments · Fixed by #64 or #74
Closed

Introduce ROCK automations for building and pushing ROCKs #58

kimwnasptd opened this issue Nov 20, 2023 · 0 comments · Fixed by #64 or #74
Labels
enhancement New feature or request

Comments

@kimwnasptd
Copy link
Contributor

What needs to get done

Similarly to what we have in kubeflow-rocks repo

  1. A workflow for building ROCKs on each PR
    https://github.com/canonical/kubeflow-rocks/blob/main/.github/workflows/on_pull_request.yaml
  2. A workflow for automatically building/publishing a ROCK
    https://github.com/canonical/kubeflow-rocks/blob/main/.github/workflows/build_and_publish_rock.yaml

Why it needs to get done

To reduce the manual work required of testing that images can be built and published
@kimwnasptd kimwnasptd added the enhancement New feature or request label Nov 20, 2023
This was referenced Nov 28, 2023
Closed
Closed
Merged
@ca-scribner ca-scribner mentioned this issue Nov 29, 2023
Closed
@orfeas-k orfeas-k mentioned this issue Dec 1, 2023
Merged
orfeas-k added a commit that referenced this issue Dec 5, 2023
@orfeas-k
feat(ci): Introduce automation for building, pushing and testing ROCKs (
788924a 
#64)

- ci: Introduce workflows in order to:
     * Build and publish ROCK on dispatch.
     * Build, scan and run sanity and integration tests on PR for each ROCK that 
     was modified by it. 
- tests: Add `sanity` tox environment that replicates the `unit` one without the
  `copy-rock-to-docker` and `rockcraft pack` part. This way, those steps
  are decoupled and tests can be triggered from integrate.yaml workflow.
- files: Add `.gitignore`

Closes #58
@orfeas-k orfeas-k mentioned this issue Dec 13, 2023
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@kimwnasptd