Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin pyright to 1.1.344 #4512

Merged
merged 2 commits into from Jan 9, 2024
Merged

ci: pin pyright to 1.1.344 #4512

merged 2 commits into from Jan 9, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Pin pyright because patch releases are breaking CI.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from lengau and syu-w January 8, 2024 21:22
@mr-cal mr-cal mentioned this pull request Jan 8, 2024
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6c5a60) 89.22% compared to head (12c3d5f) 89.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4512      +/-   ##
==========================================
- Coverage   89.22%   89.20%   -0.02%     
==========================================
  Files         322      321       -1     
  Lines       21808    21759      -49     
==========================================
- Hits        19458    19411      -47     
+ Misses       2350     2348       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌

@mr-cal mr-cal merged commit ffbdabf into main Jan 9, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the pin-pyright-2 branch January 9, 2024 15:51
sergiusens pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
syu-w pushed a commit that referenced this pull request Jan 29, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants