Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install snapd from edge inside build environments #4514

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 9, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

  1. Install snapd from edge inside build environments
  2. Update spread tests to exercise build environments (two tests use lxd, one uses destructive-mode)

Note:
Installing snapd from edge exposed a minor bug in craft-providers 1.20.1. However, that bug was mercifully fixed in the 1.19.3 hotfix (which was released and merged to main after 1.20.1 and there hasn't been a release on main since). So To get this prototype out the door, I'm just pointing to main for craft-providers and I'll do a release soon.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from lengau and syu-w and removed request for lengau January 9, 2024 21:45
@syu-w
Copy link
Contributor

syu-w commented Jan 9, 2024

snapd edge only for this test or you want to use it for all builds? Or the components support needs it?

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 9, 2024

pyright failure fixed in #4512, which has not been cherry-picked to this branch

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 9, 2024

snapd edge only for this test or you want to use it for all builds? Or the components support needs it?

It's only needed only when components are being built.

I could set the snapd channel based on whether components are being built.

I decided to do the simple approach because by the time this is ready to merge into main, snapd will support components on latest/stable and I'll be able remove this from the experimental feature branch.

@mr-cal mr-cal merged commit 45968ff into feature/components Jan 9, 2024
8 of 10 checks passed
@mr-cal mr-cal deleted the component-improvements branch January 9, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants