feat!: fail if we know the project is core24 #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4557 +/- ##
=============================================================
- Coverage 88.33% 88.20% -0.13%
=============================================================
Files 327 327
Lines 21961 21992 +31
=============================================================
Hits 19399 19399
- Misses 2562 2593 +31 ☔ View full report in Codecov by Sentry. |
tigarmo
force-pushed
the
CRAFT-2441-craft-app-core24-only
branch
6 times, most recently
from
f793720
to
4fb3c6b
Compare
tigarmo
force-pushed
the
CRAFT-2441-craft-app-core24-only
branch
from
4fb3c6b
to
1372d07
Compare
syu-w
reviewed
Feb 6, 2024
This commit updates the scaffolding to have a different behavior in cases where we *know* that the existing project (from the yaml file) is core24-based. In these cases, we now raise a RuntimeError outlining the name of the command instead of raising a ClassicFallback error to let the non-craft-application workflow take over. With this, Snapcraft runs on core24 projects will fail until the commands are ported over, while projects for older bases (or commands that don't use projects, like "init") will still fallback to the existing behavior.
These are all the tests from tests/spread/core22, copied over to tests/spread/core24. Completely unmodified, they therefore still have the core22 base.
This is a semi-manual update of "base" to "core24", "build-base" to "devel" and "grade" to "devel" (where applicable).
This commit does the equivalent of pytest's "xfail(strict=True)": all core24 tests are currently fail because no Snapcraft command has been implemented yet, so the test checks that the tool fails with the expected message, and then exits successfully. The idea is that once a command is implemented the corresponding spread tests will start to fail - we can then scrutinize each test to validate the new behavior.
tigarmo
force-pushed
the
CRAFT-2441-craft-app-core24-only
branch
from
e76e2fd
to
0abe95e
Compare
|
I had to force-push this to re-seat it on the new |
syu-w
approved these changes
Feb 7, 2024
mr-cal
approved these changes
Feb 8, 2024
The intention here is to speed-up spread runs and make the development loop faster. I've run the non-core24-tests in this feature branch and can confirm that they pass (or have unrelated failures).
tigarmo
force-pushed
the
CRAFT-2441-craft-app-core24-only
branch
from
0abe95e
to
d8567cd
Compare
thanks! I updated the workflow to keep the name of the required step |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is two-fold:
A lot of the changes are copied over from existing tests, so some commits can mostly be skimmed. I tried to split them up in a way that makes functional sense (to me at least):
tests/spread/core22/. These tests are unchanged and still havecore22as base, so they don't need a big review;snapcraft packare expected to fail with"pack" command is not implemented for core24. The tests now check for this message and exit.tests/spread/core24. I confirmed that the other tests are passing, and restricting this feature-branch to only core24 tests speeds up the development loop considerably.