Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: fail if we know the project is core24 #4557

Merged
merged 5 commits into from
Feb 8, 2024

Commits on Feb 7, 2024

  1. feat!: fail if we know the project is core24

    This commit updates the scaffolding to have a different behavior in
    cases where we *know* that the existing project (from the yaml file) is
    core24-based.
    
    In these cases, we now raise a RuntimeError outlining the name of the
    command instead of raising a ClassicFallback error to let the
    non-craft-application workflow take over.
    
    With this, Snapcraft runs on core24 projects will fail until the
    commands are ported over, while projects for older bases (or commands
    that don't use projects, like "init") will still fallback to the
    existing behavior.
    tigarmo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    44ad4e0 View commit details
    Browse the repository at this point in the history
  2. chore(spread): add many core24 tests

    These are all the tests from tests/spread/core22, copied over to
    tests/spread/core24. Completely unmodified, they therefore still have
    the core22 base.
    tigarmo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a558fd9 View commit details
    Browse the repository at this point in the history
  3. chore(spread): fix bases in core24 tests

    This is a semi-manual update of "base" to "core24", "build-base" to
    "devel" and "grade" to "devel" (where applicable).
    tigarmo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    14e20be View commit details
    Browse the repository at this point in the history
  4. fix(spread): set expected failures for core24 tests

    This commit does the equivalent of pytest's "xfail(strict=True)": all
    core24 tests are currently fail because no Snapcraft command has been
    implemented yet, so the test checks that the tool fails with the
    expected message, and then exits successfully.
    
    The idea is that once a command is implemented the corresponding spread
    tests will start to fail - we can then scrutinize each test to validate
    the new behavior.
    tigarmo committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    376e7d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. ci(spread): only run core24 spread tests

    The intention here is to speed-up spread runs and make the development
    loop faster. I've run the non-core24-tests in this feature branch and
    can confirm that they pass (or have unrelated failures).
    tigarmo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d8567cd View commit details
    Browse the repository at this point in the history