keyboard: fix wrong keyboard layout in initramfs #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the installation, in the curthooks stage, curtin generates the initramfs. Unfortunately, the generated initramfs did not honor the keyboard mapping selected by the user during installation. Therefore, when LUKS encryption is used for the root file-system, the prompt for the passphrase ignores the keyboard layout set by the user. To ensure that the initramfs uses the right keyboard layout, the /etc/console-setup/cached_* files must be updated before the initramfs gets created. At the beginning of the curthooks stage, we now call setupcon --save-only in the target to refresh those files if needed. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
dbungert
reviewed
Sep 9, 2022
dbungert
approved these changes
Sep 9, 2022
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
dbungert
approved these changes
Sep 12, 2022
|
I realize we don't really have the setup for this now, but given we run each curtin 'stage' separately, we don't need to get curtin to run these commands for us, we can just run them ourselves (this is true for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the installation, in the curthooks stage, curtin generates the initramfs. Unfortunately, the generated initramfs did not honor the keyboard mapping selected by the user during installation. Therefore, when LUKS encryption is used for the root file-system, the prompt for the passphrase ignores the keyboard layout set by the user.
To ensure that the initramfs uses the right keyboard layout, the
/etc/console-setup/cached_*files must be updated before the initramfs gets created. At the beginning of the curthooks stage, we now callsetupcon --save-onlyin the target to refresh those files if needed.This PR addresses https://bugs.launchpad.net/subiquity/+bug/1894009