First version of the tls-requirer operator
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| provider_relation_data = _load_relation_data(event.relation.data[self.charm.app]) | ||
| if not self._relation_data_is_valid(requirer_relation_data): | ||
| logger.warning( | ||
| f"Relation data did not pass JSON Schema validation: {requirer_relation_data}" |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| content=certificate_secret_content, | ||
| label=CERTIFICATE_SECRET_LABEL, | ||
| ) | ||
| logger.info(f"New certificate is stored: {event.certificate}") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
ghislainbourgeois
requested changes
May 15, 2023
Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@gmail.com>
Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@gmail.com>
ghislainbourgeois
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
First version of the
tls-requireroperator. Charm that requests X.509 certificates using thetls-certificatesinterface.It uses the user-provided
subjectconfiguration to generate a certificate signing request(CSR) that will be inserted into its unit relation data as soon as the
tls-certificatesrelationis created. In return, the certificate provider should use this CSR, generate a certificate,
and provide it back into their application relation data.
This charm is useful when developing and testing certificate providers.
Usage
Deploy the charm and relate it to a certificate provider:
Access the generated certificate:
Limitations
This charm doesn't scale up.
Relations
tls-certificates: Used for charms that require/provide TLS certificates.