Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traefik route endpoint #44

Closed
wants to merge 29 commits into from
Closed

Traefik route endpoint #44

wants to merge 29 commits into from

Conversation

PietroPasotti
Copy link
Collaborator

@PietroPasotti PietroPasotti commented Apr 13, 2022

Feature

This PR adds an integration with the Traefik Route charm (cf. https://github.com/PietroPasotti/traefik-route-k8s-operator), enabling users to configure Traefik on a per-relation basis, overcoming the limitations of ingress-per-unit and ingress-per-app, making Traefik a lot more general.

The role of Traefik in this integration is very limited: it simply has to accept a yaml config file and write it to the folder where traefik will load it up. Therefore the changes to the charm codebase are rather limited.

Testing Instructions

Aside from running the utests, you can test this in combination with TraefikRoute and prometheus-k8s in a live deployment (itests pending).

juju deploy traefik-route-k8s --channel beta

Release Notes

  • Added traefik_route_k8s/v0/traefik_route.py lib
  • Added traefik_route integration in the Traefik charm.

@PietroPasotti PietroPasotti requested review from jnsgruk, mmanciop and simskij and removed request for jnsgruk April 13, 2022 08:25
lib/charms/traefik_route_k8s/v0/traefik_route.py Outdated Show resolved Hide resolved
lib/charms/traefik_route_k8s/v0/traefik_route.py Outdated Show resolved Hide resolved
lib/charms/traefik_route_k8s/v0/traefik_route.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.observability_libs.v0.kubernetes_service_patch was already up to date in version 0.6.                                                           
Library charms.prometheus_k8s.v0.prometheus_scrape was already up to date in version 0.17.                                                                     
Library charms.traefik_k8s.v0.ingress was already up to date in version 0.5.   
Library charms.traefik_k8s.v0.ingress_per_unit has local changes, cannot be updated.                                                                           
Library charms.traefik_route_k8s.v0.traefik_route was already up to date in version 0.1.                                                                       

stderr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants