-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: fix for default web browser #16
settings: fix for default web browser #16
Conversation
3371e9a
to
47cd4b9
Compare
66989fb
to
3eae3f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 78.61% 78.57% -0.04%
==========================================
Files 992 992
Lines 122905 122935 +30
==========================================
- Hits 96620 96597 -23
- Misses 20210 20250 +40
- Partials 6075 6088 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
560744a
to
fcba778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be simplified a bit by dropping the xdg-open and xdg-settings proxy scripts from core22-desktop and replacing them with the xdg-utils versions. I don't think there is anything in ubuntu-desktop-session that needs the proxies, and this would simplify the snapd changes here, since snap userd
could just rely on the scripts in /usr/bin.
With luck, this would also fix snaps trying to use the xdg-open proxy...
5a11dee
to
148e991
Compare
gnome-control-center might call xdg-settings in the default apps panel. |
It doesn't. It uses the |
This fix allows to set and check the default web browser, thus removing the nasty message that Firefox isn't your default browser. It basically copies the original xdg-settings and xdg-mime scripts inside snapd, and calls the former with the full path. Also, the former has been modified to call the xdg-mime script located inside snapd.
f543041
to
6c0ae5a
Compare
This patch complements canonical/ubuntu-core-desktop-snapd#16 to allow to set the default web browser in core desktop.
81b1254
to
bc7b34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now
This fix allows to set and check the default web browser, thus removing the nasty message that Firefox isn't your default browser.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?