Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

The decoration title is cut when selecting another language #670

Closed
seb128 opened this issue Feb 9, 2022 · 11 comments · Fixed by #1329
Closed

The decoration title is cut when selecting another language #670

seb128 opened this issue Feb 9, 2022 · 11 comments · Fixed by #1329

Comments

@seb128
Copy link
Collaborator

seb128 commented Feb 9, 2022

Using the current canary daily with rev288, if you select another language on the first screen the win title is cut, for example in french it displays 'Installer Ub...'. That's in a gnome boxes instance but the resolution choice doesn't seem to change the result

@jpnurmi
Copy link
Contributor

jpnurmi commented Feb 9, 2022

This might be somehow connected to the rendering issue. The title is sometimes ok and sometimes cut, when activating and deactivating the window back and forth. The close button has often rendering issues at the same time when the title gets cut.

Inactive Active
Screenshot from 2022-02-09 15-07-46 Screenshot from 2022-02-09 15-07-38

P.S. The screenshots were taken without libhandy to eliminate it out.

@jpnurmi
Copy link
Contributor

jpnurmi commented Feb 9, 2022

titlebar.mp4

@jpnurmi
Copy link
Contributor

jpnurmi commented Feb 18, 2022

I'll double check after lunch but I think https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1960947 solves this too!

@jpnurmi
Copy link
Contributor

jpnurmi commented Mar 7, 2022

Even though this is clearly more like a layout calculation issue, I can't seem to be able to reproduce this after LP#1960947 has landed. It's a bit strange that a miscalculated OpenGL update area would have a side-effect like this, but perhaps it leaves an intermediate layout visible due to a missing redraw.

@jpnurmi
Copy link
Contributor

jpnurmi commented Mar 7, 2022

window-title.mp4
ubuntu@ubuntu:~$ snap info ubuntu-desktop-installer 
name:      ubuntu-desktop-installer
summary:   Ubuntu Desktop Installer
publisher: Canonical✓
store-url: https://snapcraft.io/ubuntu-desktop-installer
contact:   https://bugs.launchpad.net/ubuntu-desktop-installer
license:   unset
description: |
  This project is a modern implementation of the Ubuntu Desktop installer,
  using subiquity as a backend and Flutter for the UI.
commands:
  - ubuntu-desktop-installer.os-prober
  - ubuntu-desktop-installer.probert
  - ubuntu-desktop-installer.subiquity-loadkeys
  - ubuntu-desktop-installer
services:
  ubuntu-desktop-installer.subiquity-server: simple, enabled, active
snap-id:      rQm0TtMOYOtEslvEXgxQDhgy1JNn38Wz
tracking:     latest/stable/ubuntu-22.04
refresh-date: today at 08:30 UTC
channels:
  latest/stable:    0+git.b49fe8d 2022-03-02 (313) 132MB classic
  latest/candidate: 0+git.a7c8632 2022-03-03 (320) 132MB classic
  latest/beta:      ↑                                    
  latest/edge:      ↑                                    
installed:          0+git.a7c8632            (320) 132MB classic

@jpnurmi
Copy link
Contributor

jpnurmi commented Mar 7, 2022

The title is elided even shorter when running integration tests

Screenshot from 2022-03-07 16-42-11

integration_test2.mp4

@jpnurmi
Copy link
Contributor

jpnurmi commented Mar 16, 2022

A minimal Flutter app + integration test that reproduces the issue: flutter_window_title_issue. I've added a long list of notes there too.

@jpnurmi
Copy link
Contributor

jpnurmi commented Jan 3, 2023

daily-live 20230103
image

@jpnurmi
Copy link
Contributor

jpnurmi commented Jan 3, 2023

We could replace the GTK header bar with a Flutter widget when I'm done with:

@jpnurmi

This comment was marked as outdated.

@jpnurmi
Copy link
Contributor

jpnurmi commented Jan 11, 2023

Screencast.from.2023-01-11.15-31-20.webm
Screencast.from.2023-01-11.15-08-42.webm

jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 17, 2023
Allow pages to pass any PreferredSizeWidget to make it possible to
replace it with YaruWindowTitleBar.

Ref: canonical#670
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 17, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 17, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 17, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 17, 2023
Allow pages to pass any PreferredSizeWidget to make it possible to
replace it with YaruWindowTitleBar.

Ref: canonical#670
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 17, 2023
jpnurmi added a commit that referenced this issue Jan 19, 2023
Allow pages to pass any PreferredSizeWidget to make it possible to
replace it with YaruWindowTitleBar.

Ref: #670
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 19, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 19, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 20, 2023
jpnurmi added a commit that referenced this issue Jan 20, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 20, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 20, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 24, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 24, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 24, 2023
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 27, 2023
jpnurmi added a commit that referenced this issue Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants