This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add --try-or-install command-line option #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarlosNihelton I guess we can live with this property drilling for now but I think soon it's time to introduce a top-level app model as you did in the WSL setup. :) |
jpnurmi
commented
Jan 20, 2023
| builder: WelcomePage.create, | ||
| onNext: (_) { | ||
| if (tryOrInstall == true) { | ||
| return Routes.tryOrInstall; |
There was a problem hiding this comment.
these lines are covered by the integration test even though we don't collect coverage info for them because by running the entire app it'd be too easy to cover 100% :P
CarlosNihelton
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the Try or install page unless requested by passing
--try-or-install.Ref: #1307