This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
force-pushed
the
autoinstall
branch
3 times, most recently
from
February 17, 2023 17:12
3e8890b
to
64dd345
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Feb 20, 2023
Split off from canonical#1412 and coupled with a unit test. Make sure to call `GET /storage/v2?wait=true` before calling `GET /storage/v2/orig_config` because only the former blocks until Subiquity is done probing the hardware. The correct order is important in autoinstall mode because the GUI jumps straight to the confirmation screen after establishing a connection. Subiquity might be still probing the hardware in the background at that point.
jpnurmi
added a commit
that referenced
this pull request
Feb 20, 2023
Split off from #1412 and coupled with a unit test. Make sure to call `GET /storage/v2?wait=true` before calling `GET /storage/v2/orig_config` because only the former blocks until Subiquity is done probing the hardware. The correct order is important in autoinstall mode because the GUI jumps straight to the confirmation screen after establishing a connection. Subiquity might be still probing the hardware in the background at that point.
d-loose
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Semi-automated installation with interactive sections is not supported, yet.