Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Make WizardPage's constants and themes available #142

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Jul 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #142 (55fdead) into main (ecda535) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          27       27           
  Lines        1102     1102           
=======================================
  Hits          781      781           
  Misses        321      321           
Impacted Files Coverage Δ
...ckages/ubuntu_desktop_installer/lib/app_theme.dart 100.00% <100.00%> (ø)
...buntu_desktop_installer/lib/pages/wizard_page.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecda535...55fdead. Read the comment docs.

@oSoMoN
Copy link
Contributor

oSoMoN commented Jul 9, 2021

LGTM, thanks!

@oSoMoN oSoMoN merged commit 67f6241 into canonical:main Jul 9, 2021
@jpnurmi jpnurmi deleted the constants-themes branch July 9, 2021 16:09
@Feichtmeier
Copy link
Contributor

@jpnurmi the availible sizes look great, but I don't think it is a good idea to use installer specific hard coded colors.
Can't you get those from Theme.of(context) .... ? Yaru.dart should give you all you need. This reduces the chance of having stuff not dark mode compatible

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Jul 9, 2021

Sounds good! I didn't make any changes to any of the values in this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants