Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Redesigned installation slides #1598

Merged
merged 12 commits into from
Mar 15, 2023
Merged

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Mar 12, 2023

Light

installation-slides-light.webm

Dark

installation-slides-dark.webm

@jpnurmi jpnurmi force-pushed the installation-slides branch 9 times, most recently from 4fd2da5 to b00e98c Compare March 14, 2023 15:33
@jpnurmi jpnurmi marked this pull request as ready for review March 14, 2023 16:04
@elioqoshi elioqoshi added this to the Lunar design QA milestone Mar 15, 2023
@jpnurmi jpnurmi requested a review from d-loose March 15, 2023 10:50
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Mar 15, 2023

P.S. I still need to double-check that all screenshots and image assets look fine on a high-DPI display but implementation-wise this is ready for review. :)

P.P.S. The diff is massive because of translations. The only interesting file is app_en.arb but besides that, you can just collapse and ignore the l10n folder.

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Mar 15, 2023

@elioqoshi we need the new mascot for the first slide :)

Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. I still need to double-check that all screenshots and image assets look fine on a high-DPI display but implementation-wise this is ready for review. :)

Some screenshots are blurry at least when viewed at full screen (1920x1080)

Implementation-wise: LGTM 👍

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Mar 15, 2023

Normally, the window size is fixed to 960x680. It may end up being a bit smaller (we have promised to support down to 800x600 screens) or even slightly larger when shown full screen because for example a 1024x768 screen doesn't have enough space to show a 960x680 window after deducting the dock size etc.

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Mar 15, 2023

Alrighty, let's merge this! We'll fine-tune the screenshots separately case by case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants