Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fix and clean up url launcher tests #947

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Jun 23, 2022

The platform interface has changed so that all launch options are
bundled into an object. We don't really care about the exact options,
just using the defaults, so it can be "any" instead of trying to match
the values.

The platform interface has changed so that all launch options are
bundled into an object. We don't really care about the exact options,
just using the defaults, so it can be "any" instead of trying to match
the values.
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Jun 23, 2022

This fixes the test failure in #946:

00:37 +74 -1: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: can launch [E]                                                   
  type 'Null' is not a subtype of type 'Future<bool>'
  package:url_launcher_platform_interface/src/url_launcher_platform.dart 72:16  MockUrlLauncherPlatform.launchUrl
  package:url_launcher/src/url_launcher_string.dart 33:45                       launchUrlString
  package:ubuntu_wizard/src/utils/url_launcher.dart 18:12                       UrlLauncher.launchUrl
00:37 +74 -1: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: cannot launch                                                    
00:37 +75 -1: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: cannot launch                                                    
00:37 +75 -1: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: launch fail                                                      
00:37 +75 -2: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: launch fail [E]                                                  
  type 'Null' is not a subtype of type 'Future<bool>'
  package:url_launcher_platform_interface/src/url_launcher_platform.dart 72:16  MockUrlLauncherPlatform.launchUrl
  package:url_launcher/src/url_launcher_string.dart 33:45                       launchUrlString
  package:ubuntu_wizard/src/utils/url_launcher.dart 18:12                       UrlLauncher.launchUrl
00:37 +75 -2: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: service                                                          
00:37 +75 -3: /home/runner/work/ubuntu-desktop-installer/ubuntu-desktop-installer/packages/ubuntu_wizard/test/url_launcher_test.dart: service [E]                                                      
  type 'Null' is not a subtype of type 'Future<bool>'
  package:url_launcher_platform_interface/src/url_launcher_platform.dart 72:16  MockUrlLauncherPlatform.launchUrl
  package:url_launcher/src/url_launcher_string.dart 33:45                       launchUrlString
  package:ubuntu_wizard/src/utils/url_launcher.dart 18:12                       UrlLauncher.launchUrl

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Cleanups are always welcome!

@jpnurmi jpnurmi merged commit 448a8c6 into canonical:main Jun 27, 2022
@jpnurmi jpnurmi deleted the url-launcher branch June 27, 2022 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants