Skip to content

Commit

Permalink
feat(ubuntu_widgets): use fixed padding for MenuButtonBuilder (#334)
Browse files Browse the repository at this point in the history
  • Loading branch information
d-loose committed Oct 30, 2023
1 parent 5eb0847 commit 5856134
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions packages/ubuntu_widgets/lib/src/menu_button_builder.dart
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,9 @@ class _MenuButtonBuilderState<T> extends State<MenuButtonBuilder<T>> {
if (widget.onSelected == null) MaterialState.disabled,
};

final direction = Directionality.of(context);

final button = OutlinedButtonTheme.of(context).style;
final minimumSize = button?.minimumSize?.resolve(states);
final maximumSize = button?.maximumSize?.resolve(states);
final padding = button?.padding?.resolve(states)?.resolve(direction);

return MenuItemButton(
focusNode: states.contains(MaterialState.selected) ? _focusNode : null,
Expand All @@ -268,7 +265,7 @@ class _MenuButtonBuilderState<T> extends State<MenuButtonBuilder<T>> {
minimumSize: minimumSize ?? const Size(0, _kItemHeight),
maximumSize:
maximumSize ?? const Size(double.infinity, _kItemHeight),
padding: padding ?? _scaledPadding(context),
padding: _scaledPadding(context),
textStyle: Theme.of(context).textTheme.labelLarge,
),
child: item.child ?? widget.itemBuilder(context, item.value, null),
Expand Down

0 comments on commit 5856134

Please sign in to comment.