TimezoneMap: fix fractional timezone offset formatting #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When formatting fractional timezone offsets, force the "en_US" locale to ensure that "." is used as the decimal separator instead of "," that some (e.g. nordic) locales use. This fixes the issue that depending on the value of `Intl.defaultLocale`, the map would try to load SVGs with wrong file names such as "tz_5,5.svg" instead of "tz_5.5.svg" for India.
spydon
pushed a commit
to spydon/ubuntu-flutter-plugins
that referenced
this pull request
Nov 17, 2023
cleanup DevicePage and ReleasePage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formatting fractional timezone offsets, force the "en_US" locale
to ensure that "." is used as the decimal separator instead of "," that
some (e.g. nordic) locales use.
This fixes the issue that depending on the value of
Intl.defaultLocale,the map would try to load SVGs with wrong file names such as "tz_5,5.svg"
instead of "tz_5.5.svg" for India.