-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial content for explanation/merges and syncs #53
base: 2.0-preview
Are you sure you want to change the base?
Conversation
I looked through the CI errors:
|
I would agree with adding it to the linkcheck ignore. I think that would be better than increasing the timeout time, otherwise people working on PRs or making contributions will end up having frustrating experiences with the tests.
I was having the same issue with manpages.ubuntu.com links in Pro docs. I couldn't see any legitimate reason for it, and the links were working when I clicked on them. I'd be a bit more hesitant about adding that to linkcheck ignore though, since there might be genuinely broken pages among those, which we will want to at least be prompted to check. |
Fully agree, but I also do not know how to proceed here. Manually checking links every time can't be the solution :/ |
Merge-o-Matic has a long loading time that is erroneously marked as broken, because of linkcheck timeouts. Additionally, loading Merge-o-Matic is sometimes flaky.
9067773
to
36624cb
Compare
suggestion: I could write a script that greps all :manpage:`value` and check it with curl and tell linkcheck to ignore manpage.ubuntu.com. |
I through together this script. It even has the benefit of de-duplicating manpage checks. #!/usr/bin/env bash
manpages=$(grep \
--basic-regexp ':manpage:`.\+`' \
--only-matching \
--recursive --include '*.rst' docs \
| cut --delimiter '`' --fields 2 \
| sort --unique)
pass=true
for manpage in $manpages
do
# assuming the pattern "PAGE(SECTION)"
page="${manpage%%(*}"
section="${manpage#*(}"
section="${section%)*}"
url="https://manpages.ubuntu.com/manpages/en/man${section}/${page}.${section}.html"
if curl --silent --show-error $url > /dev/null
then
echo "INFO: Tested $manpage successfully (URL='$url')."
else
pass=false
echo "ERROR: Failed to load manpage $manpage (URL='$url')."
fi
done
if $pass
then
echo "PASS: All manpages were accessible."
else
echo "FAIL: One or more manpage(s) did not load properly."
exit 1
fi
|
This PR adds the initial content for the explanation of syncs and merges from Debian unstable.