Add initial content for explanantion/development process #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dviererbe
added a commit
that referenced
this pull request
May 2, 2024
dviererbe
added a commit
that referenced
this pull request
May 2, 2024
s-makin
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Sorry for the delay in my review, this fell off my radar with the sprint. Mainly US -> UK spelling and de-capitalising headers, although I have a couple of other questions/suggestions as well. I don't know if we're still using US spelling in the Packaging Guide, but if we are there are some spellings that will need to go from UK to US (you've got a mixture of both in here :D)
dviererbe
force-pushed
the
explanation/merges-and-syncs
branch
from
ba593a1
to
9b95e0c
Compare
dviererbe
added a commit
that referenced
this pull request
Jul 8, 2024
dviererbe
force-pushed
the
explanation/merges-and-syncs
branch
from
9b95e0c
to
6741ace
Compare
|
Note This PR got closed, because I fixed a spelling mistake in the branch name. See #62 for the continuation of this PR. |
dviererbe
added a commit
that referenced
this pull request
Jul 8, 2024
See #54 Co-authored-by: Sally Makin <sally.makin@canonical.com> Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
dviererbe
added a commit
that referenced
this pull request
Jul 8, 2024
Incorporates feedback from Sally Makin <sally.makin@canonical.com>: > It's not quite clear what the definition of a freeze is here. > I think we could be a bit more explicit about what we mean by > "freeze", to avoid using the term without making it really clear > what the term means. See: - #54 (comment) - #62 (comment) - #62 (comment) Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
dviererbe
added a commit
that referenced
this pull request
Jul 8, 2024
Incorporates feedback from Sally Makin <sally.makin@canonical.com>: > It's not quite clear what the definition of a freeze is here. > I think we could be a bit more explicit about what we mean by > "freeze", to avoid using the term without making it really clear > what the term means. See: - #54 (comment) - #62 (comment) - #62 (comment) Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR is targeted against #53 for better readability of the diff. Set the base to the
2.0-previewbranch before merging!This PR adds the initial content for the explanation article of the Ubuntu development process.