-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide error message when value changes #12759
Hide error message when value changes #12759
Conversation
Demo starting at https://ubuntu-com-12759.demos.haus |
Codecov Report
@@ Coverage Diff @@
## main #12759 +/- ##
==========================================
- Coverage 73.68% 73.55% -0.13%
==========================================
Files 104 104
Lines 2709 2715 +6
Branches 840 842 +2
==========================================
+ Hits 1996 1997 +1
- Misses 685 690 +5
Partials 28 28
|
d15cbbf
to
847f00a
Compare
847f00a
to
9fcd10a
Compare
9fcd10a
to
6a18d6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this implementation. It touches too many components.
I was hoping Formik has a onChange handler. I googled a bit and found this: https://plainenglish.io/blog/how-to-listen-to-formik-onchange-event-in-react
But the FormObserver
, did not work as expected.
But rather than a component, perhaps having just a simple JS event listener for all input
and select
HTML elements that would hide the notification once it is displayed is enough.
Either way.. I would rather always have the notification up than add all these new changes to the components.
Closing this PR as the ticket has been moved into ice box. |
Done
QA
Issue / Card
Fixes #https://warthogs.atlassian.net/jira/software/c/projects/WD/boards/801?modal=detail&selectedIssue=WD-2941