-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-3904-credentials-schedule #12988
WD-3904-credentials-schedule #12988
Conversation
Demo starting at https://ubuntu-com-12988.demos.haus |
Codecov Report
@@ Coverage Diff @@
## main #12988 +/- ##
=======================================
Coverage 74.90% 74.90%
=======================================
Files 107 107
Lines 2873 2873
Branches 928 928
=======================================
Hits 2152 2152
Misses 699 699
Partials 22 22 |
@abhigyanghosh30 where can I view the demo, demohaus only leads to ubuntu.com when I add the '/credentials/schedule?contractItemID=' it's a 404. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhigyanghosh30 here's some reviews for the html i'll leave a CSS comment in a bit.
The background color is #f3f3f3 or $color-paper. thank you! |
This is for the entire page or the input boxes? Because currently, the input boxes have #f2f2f2 as the default colour. |
Does the 2.7rem margin apply to all the input sections? |
The input box color with paper background is adjusted to rgba(0,0,0,.04) |
Yes 😄 |
@camillet16 made changes as requested. Please review again |
Done
QA
./run serve
ordotrun
Issue / Card
Fixes # WD-3904
Screenshots
Help
QA steps - Commit guidelines