Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lxd link in meganav #13020

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Update lxd link in meganav #13020

merged 1 commit into from
Jul 6, 2023

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Jul 6, 2023

Done

  • update link for lxd in meganav

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • check meganav (product link on the top) for the lxd link, it should point to /lxd and not to the external linuxcontainers.org page

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13020.demos.haus

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #13020 (181af77) into main (5942bb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13020   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files         104      104           
  Lines        2774     2774           
  Branches      869      869           
=======================================
  Hits         2075     2075           
  Misses        677      677           
  Partials       22       22           

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but personally I believe that if there are any more "TEMP FIXes" needed they should all be properly moved to global-nav codebase

@mtruj013
Copy link
Contributor

mtruj013 commented Jul 6, 2023

@bartaz I believe they are already covered in the wip version, at least the one's Pete and I added. Not sure about this one though, might be worth checking with @petesfrench or @juanruitina. The idea is that all of this can be deleted once the new version of the global nav is green lit

@bartaz
Copy link
Member

bartaz commented Jul 6, 2023

@bartaz I believe they are already covered in the wip version

@mtruj013 thanks for context, can you point @edlerd to the new meganav branch/PR to make sure this change is reflected there as well, and doesn't get lost when updated?

@mtruj013
Copy link
Contributor

mtruj013 commented Jul 6, 2023

@edlerd @bartaz I think it's this one #12939. But please do reach out to Pete or Juan if you have any questions, they're the ones working on it and will for sure know more than me

@petesfrench petesfrench mentioned this pull request Jul 6, 2023
@edlerd edlerd merged commit 1948430 into main Jul 6, 2023
27 of 28 checks passed
@edlerd edlerd deleted the update-lxd-link-in-nav branch July 6, 2023 14:26
@edlerd edlerd restored the update-lxd-link-in-nav branch July 6, 2023 14:26
@edlerd
Copy link
Contributor Author

edlerd commented Jul 6, 2023

@edlerd @bartaz I think it's this one #12939. But please do reach out to Pete or Juan if you have any questions, they're the ones working on it and will for sure know more than me

Thanks for the pointer, This change is in the main branch of the global-nav project already and also in the latest release 3.2.5 of it.
I'll check with the stakeholders if more adjustments are needed.

@edlerd edlerd deleted the update-lxd-link-in-nav branch July 6, 2023 14:28
@juanruitina
Copy link
Contributor

FYI, we are already using the new link on the Ubuntu.com meganav demo, and I see the global nav component is already updated, so we shouldn't have any issues on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants