-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lxd link in meganav #13020
Update lxd link in meganav #13020
Conversation
Demo starting at https://ubuntu-com-13020.demos.haus |
Codecov Report
@@ Coverage Diff @@
## main #13020 +/- ##
=======================================
Coverage 74.80% 74.80%
=======================================
Files 104 104
Lines 2774 2774
Branches 869 869
=======================================
Hits 2075 2075
Misses 677 677
Partials 22 22 |
5090fc7
to
181af77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but personally I believe that if there are any more "TEMP FIXes" needed they should all be properly moved to global-nav codebase
@bartaz I believe they are already covered in the wip version, at least the one's Pete and I added. Not sure about this one though, might be worth checking with @petesfrench or @juanruitina. The idea is that all of this can be deleted once the new version of the global nav is green lit |
Thanks for the pointer, This change is in the main branch of the global-nav project already and also in the latest release 3.2.5 of it. |
FYI, we are already using the new link on the Ubuntu.com meganav demo, and I see the global nav component is already updated, so we shouldn't have any issues on that front. |
Done
QA
./run serve
ordotrun