Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-9049 - fix contact form field not being sent #13641

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

lizzochek
Copy link
Contributor

@lizzochek lizzochek commented Mar 4, 2024

Done

The form was not sending the Comments_from_lead__c field. This happened because other forms were building this field dynamically from multiple question and removing text for the forms that have only one question for Comments_from_lead__c. This issue is fixed in this PR.

QA

  • demo link
  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8001/
  • Run through the following QA steps
  • Check that the form sends correct fields to market

Issue / Card

WD-9049

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13641.demos.haus

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (8ac389f) to head (0e18686).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13641   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         107      107           
  Lines        2847     2847           
  Branches      948      948           
=======================================
  Hits         2120     2120           
  Misses        703      703           
  Partials       24       24           

@lizzochek lizzochek merged commit 814b509 into canonical:main Mar 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants