-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
New vanilla website #4430
New vanilla website #4430
Conversation
Add component menu
Add menu to all patterns
Demo starting at https://vanilla-framework-4430.demos.haus |
Noticed in QA - on the design guidelines page, the subtitles don't appear in the side nav |
Fix nav active for design
* add generate id from header * lint * replace special chars
Hi @lyubomir-popov - I added the https://vanilla-framework-4430.demos.haus/docs/patterns/accordion Shallow: Regular: |
Hi @bethcollins92, my proposal here was to decrease the space above, increase the space between the heading, to create a more deliberate look: |
49c7b1f
to
7accb76
Compare
Thanks @lyubomir-popov - made those changes |
Thanks @bethcollins92, looks good. |
Woop. @bartaz this is ready for final QA check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pages with missing title:
https://vanilla-framework-4430.demos.haus/docs/patterns/contextual-menu
https://vanilla-framework-4430.demos.haus/docs/patterns/icons
maybe others as well.
We need to find out why and fix it.
It feels weird to have more spacing on pages with tabs and no spacing on old docs without tabs. I think we should add the space to old templates as well. I guess it may end up a bigger change, not sure if we need to put it in this PR if it's too large. Edit: on a second look, it doesn't look terribly broken, so I guess we don't need to block this PR on that. But would be nice to fix that later. |
I've fixed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Done
component_tabs.yaml
file.QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots