Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p-media-container class #5012

Merged
merged 6 commits into from Mar 7, 2024
Merged

Add p-media-container class #5012

merged 6 commits into from Mar 7, 2024

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Feb 28, 2024

Done

  • Add p-media-container class which adds .5rem of spacing above media elements

Fixes #4791

QA

  • Open demo
  • See that the image in the 'Media element with spacing' section is wrapped in a container that adds 0.5rem spacing to the top
  • Check the wording of the documentation

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@petesfrench petesfrench added Review: Code needed Feature 馃巵 New feature or request Documentation 馃摑 Documentation changes or updates labels Feb 28, 2024
@webteam-app
Copy link

Demo starting at https://vanilla-framework-5012.demos.haus

scss/_base_media.scss Outdated Show resolved Hide resolved
@bartaz
Copy link
Contributor

bartaz commented Feb 29, 2024

As we are adding new feature here, that's the point when we should bump the version to 4.9.0 in package.json, but also we need to add 4.9.0 section to releases.yaml, listing the change and linking to updated docs page.

@bartaz
Copy link
Contributor

bartaz commented Mar 1, 2024

@petesfrench I guess you may need to rebase this branch on main to resolve conflicts.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot about this one. LGTM, thanks!

@bartaz bartaz merged commit 9345d2b into main Mar 7, 2024
9 checks passed
@bartaz bartaz deleted the p-media-container branch March 7, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 馃摑 Documentation changes or updates Feature 馃巵 New feature or request Review: Code +1 Review: QA +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility or class to add .5rem margin-top on images
3 participants