Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equal heights updates #5081

Merged
merged 5 commits into from
May 7, 2024
Merged

Equal heights updates #5081

merged 5 commits into from
May 7, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented May 7, 2024

Done

  • removes bottom spacing from the component
  • removes full width dividers
  • updates dividers to use low contrast border colour
  • updates divider class names to be easier to handle (from has-1st-divider to has-divider-1) (this is technically breaking change, but as it's barely used we can get away with it)

Fixes WD-10920

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@bartaz bartaz marked this pull request as ready for review May 7, 2024 14:13
@bartaz bartaz requested review from jmuzina and mas-who May 7, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants