Percy examples combination - patterns/links
#5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
jmuzina
force-pushed
the
examples-combination-patterns-links
branch
from
86c6ff3
to
fe954a5
Compare
pastelcyborg
approved these changes
Jun 20, 2024
jmuzina
force-pushed
the
examples-combination-patterns-links
branch
from
34ddfed
to
2f6dab6
Compare
bartaz
reviewed
Jun 25, 2024
| @@ -0,0 +1,5 @@ | |||
| @import '../vanilla'; | |||
There was a problem hiding this comment.
Please update to use single standalone file for all links examples, as in forms.
jmuzina
force-pushed
the
examples-combination-patterns-links
branch
from
1c1e079
to
c42fb72
Compare
bartaz
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
bartaz
merged commit e3762d6
into
canonical:percy-examples-combination
3 of 4 checks passed
jmuzina
added a commit
that referenced
this pull request
Jun 26, 2024
* patterns/links * fix inverted link breaking color of the combined example * spacing option in example template * rm combined.scss (superseded by rem spacing) * clean up link standalone combined scss * combine links standalone styles --------- Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
jmuzina
added a commit
that referenced
this pull request
Jun 27, 2024
* patterns/links * fix inverted link breaking color of the combined example * spacing option in example template * rm combined.scss (superseded by rem spacing) * clean up link standalone combined scss * combine links standalone styles --------- Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines
patterns/linksexamples.QA