Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS Error and answer leaking #3

Closed
Canop opened this issue Mar 10, 2024 · 3 comments · Fixed by #4
Closed

OS Error and answer leaking #3

Canop opened this issue Mar 10, 2024 · 3 comments · Fixed by #4
Labels
bug Something isn't working

Comments

@Canop
Copy link
Owner

Canop commented Mar 10, 2024

This started with abfb5aa

@zeenix

source: Canop/broot#854
@Canop Canop added the bug Something isn't working label Mar 10, 2024
@zeenix
Copy link
Contributor

zeenix commented Mar 10, 2024

I think the solution may be to use tty for stdout as well. I think I tested that not to work though but I'll give it another try.

@zeenix
Copy link
Contributor

zeenix commented Mar 10, 2024

I was able to reproduce this issue but it's not caused by abfb5aa since xterm-query didn't really work on Mac because of the reasons I mentioned in #2.

In fact, #4 fixes this issue.

@zeenix zeenix mentioned this issue Mar 10, 2024
Merged
@zeenix
Copy link
Contributor

zeenix commented Mar 10, 2024 •
edited
Loading

I was able to reproduce this issue but it's not caused by abfb5aa since xterm-query didn't really work on Mac because of the reasons I mentioned in #2.

Actually that's not true, sorry. My commit did cause this problem. :(

In fact, #4 fixes this issue.

This is true though.

@Canop Canop closed this as completed in #4 Mar 11, 2024
Canop added a commit that referenced this issue Mar 11, 2024
@Canop
Merge pull request #4 from zeenix/use-select-on-mac
f9c5904 
Use polling syscall directly to fix MacOS support

Fixes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use polling syscall directly to fix MacOS support zeenix/xterm-query
2 participants
@zeenix @Canop