Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lyrics: Fix syllable alignment when under chord #209

Merged
merged 1 commit into from
Oct 21, 2023
Merged

lyrics: Fix syllable alignment when under chord #209

merged 1 commit into from
Oct 21, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 21, 2023

This PR fixes:

  • syllable positioning (and consequently adding new syllables/trimming leftover syllables) in case you used chords in a single voice
  • removing leftover syllables (the index of the right-most non-empty syllable was not computed correctly)

@matevz matevz added the bug Something isn't working label Oct 21, 2023
@matevz matevz force-pushed the matevz/fix-syllable-in-chords branch from 5fc675f to bead63b Compare October 21, 2023 19:51
@matevz matevz force-pushed the matevz/fix-syllable-in-chords branch from bead63b to 30df46c Compare October 21, 2023 19:54
@suamor suamor merged commit e213f6c into main Oct 21, 2023
2 checks passed
@suamor suamor deleted the matevz/fix-syllable-in-chords branch October 21, 2023 20:24
@matevz
Copy link
Member Author

matevz commented Oct 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suamor suamor Awaiting requested review from suamor

@itsgeorg itsgeorg Awaiting requested review from itsgeorg

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @suamor