-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown command: mcfly_key_bindings on fish shell #129
Comments
Does the new version work for anyone on fish shell? I suppose the issue is that I would probably change
or figure out a way to add to call |
Sorry, I don't use fish shell. I think this is due to the changes made by @b3nj5m1n in #119, but I'm not sure. Does adding mcfly_key_bindings after like 77 of https://github.com/cantino/mcfly/blob/master/mcfly.fish help? |
@tjkirch, any help on this would also be appreciated! |
I'd personally stick with the approach from before 23ea43b. It's closer to standard and doesn't require any extra checks in the user's config. |
I don't understand why there would be any difference between |
I think the problem is https://github.com/cantino/mcfly/blob/master/mcfly.fish#L4. If I create a file Not sure what this really ensures and why we don't use https://fishshell.com/docs/current/cmds/isatty.html. If I remove the line, it works. I also think it makes sense to add |
Would you be open to making a pull request that switches to |
I don't know enough about source and isatty is say whether this is a bug in fish (like fish-shell/fish-shell#2477) or whether this is expected behavior. |
@b3nj5m1n do you have a suggestion for how to fix McFly on fish? Otherwise, I will suggest to remove the |
No, sorry but I don't use fish. I'd say try your approach. |
I sent a pull request in #137. It works for me. |
I installed McFly via home-brew. I have version McFly 0.5.4. I also added
to the end of my
config.fish
file. I have fish version 3.2.0.Even when I run
mcfly init fish | source
in my terminal,mcfly_key_bindings
is still not defined.The text was updated successfully, but these errors were encountered: