Fix rspec failure for ruby 2.3 and 2.4 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cantino Is it ok to disable the 1.9.3 build in travis. Rspec does not seem to work with that version any more. |
The FRENCH_CSV example had three columns that each could be used for date. Removed two of the columns to make the example more clear
BlackEdder
force-pushed
the
rspec_failure_french
branch
from
0dc675d
to
4430a4b
Compare
BlackEdder
changed the title
|
This is ready to merge if you are happy removing ruby 1.9 from travis. |
|
Yes, perfect! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.3 fails due to issue reported in #34