Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rspec failure for ruby 2.3 and 2.4 #69

Merged
merged 3 commits into from
Jan 3, 2017
Merged

Fix rspec failure for ruby 2.3 and 2.4 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1eea6a6
be_true was deprecated, switched to using be true
BlackEdder Jan 2, 2017
49fbcee
Enable newer ruby versions and disable deprecated 1.9.3
BlackEdder Jan 2, 2017
4430a4b
Remove ambiguous date columns from the french example
BlackEdder Jan 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
language: ruby
rvm:
- 1.9.3
- 2.0.0
- 2.3.3
- 2.4.0
script: "bundle exec rake"
26 changes: 13 additions & 13 deletions spec/reckon/csv_parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
end

it "should be in testing mode" do
@chase.settings[:testing].should be_true
Reckon::CSVParser.settings[:testing].should be_true
@chase.settings[:testing].should be true
Reckon::CSVParser.settings[:testing].should be true
end

describe "parse" do
Expand Down Expand Up @@ -71,7 +71,7 @@
@yyyymmdd_date.money_column_indices.should == [3]
@ing_csv.money_column_indices.should == [6]
@austrian_csv.money_column_indices.should == [4]
@french_csv.money_column_indices.should == [6]
@french_csv.money_column_indices.should == [4]
@broker_canada.money_column_indices.should == [8]
@intuit_mint.money_column_indices.should == [3]
end
Expand All @@ -83,7 +83,7 @@
@harder_date_example_csv.date_column_index.should == 0
@danish_kroner_nordea.date_column_index.should == 0
@yyyymmdd_date.date_column_index.should == 1
@french_csv.date_column_index.should == 2
@french_csv.date_column_index.should == 1
@broker_canada.date_column_index.should == 0
@intuit_mint.date_column_index.should == 0
end
Expand Down Expand Up @@ -354,15 +354,15 @@
CSV

FRENCH_EXAMPLE = (<<-CSV).strip
01234567890;22/01/2014;22/01/2014;CHEQUE 012345678901234578ABC000 0000 4381974748378178473744441;0000037;22/01/2014;-10,00;
01234567890;22/01/2014;22/01/2014;CHEQUE 012345678901937845500TS1 0000 7439816947047874387438445;0000038;22/01/2014;-5,76;
01234567890;22/01/2014;22/01/2014;CARTE 012345 CB:*0123456 XX XXXXXX XXX 33BORDEAUX;00X0X0X;22/01/2014;-105,90;
01234567890;22/01/2014;22/01/2014;CARTE 012345 CB:*0123456 XXXXXXXXXXX 33SAINT ANDRE D;00X0X0X;22/01/2014;-39,99;
01234567890;22/01/2014;22/01/2014;CARTE 012345 CB:*0123456 XXXXXXX XXXXX 33BORDEAUX;10X9X6X;22/01/2014;-36,00;
01234567890;22/01/2014;22/01/2014;PRLV XXXXXXXX ABONNEMENT XXXXXXXXXXXXXX.NET N.EMETTEUR: 324411;0XX0XXX;22/01/2014;-40,00;
01234567890;21/01/2014;21/01/2014;CARTE 012345 CB:*0123456 XXXXX XX33433ST ANDRE DE C;0POBUES;21/01/2014;-47,12;
01234567890;21/01/2014;21/01/2014;CARTE 012345 CB:*0123456 XXXXXXXXXXXX33433ST ANDRE DE C;0POBUER;21/01/2014;-27,02;
01234567890;21/01/2014;21/01/2014;CARTE 012345 CB:*0123456 XXXXXX XXXXXXXX33ST ANDRE 935/;0POBUEQ;21/01/2014;-25,65;
01234567890;22/01/2014;CHEQUE 012345678901234578ABC000 0000 4381974748378178473744441;0000037;-10,00;
01234567890;22/01/2014;CHEQUE 012345678901937845500TS1 0000 7439816947047874387438445;0000038;-5,76;
01234567890;22/01/2014;CARTE 012345 CB:*0123456 XX XXXXXX XXX 33BORDEAUX;00X0X0X;-105,90;
01234567890;22/01/2014;CARTE 012345 CB:*0123456 XXXXXXXXXXX 33SAINT ANDRE D;00X0X0X;-39,99;
01234567890;22/01/2014;CARTE 012345 CB:*0123456 XXXXXXX XXXXX 33BORDEAUX;10X9X6X;-36,00;
01234567890;22/01/2014;PRLV XXXXXXXX ABONNEMENT XXXXXXXXXXXXXX.NET N.EMETTEUR: 324411;0XX0XXX;-40,00;
01234567890;21/01/2014;CARTE 012345 CB:*0123456 XXXXX XX33433ST ANDRE DE C;0POBUES;-47,12;
01234567890;21/01/2014;CARTE 012345 CB:*0123456 XXXXXXXXXXXX33433ST ANDRE DE C;0POBUER;-27,02;
01234567890;21/01/2014;CARTE 012345 CB:*0123456 XXXXXX XXXXXXXX33ST ANDRE 935/;0POBUEQ;-25,65;
CSV

BROKER_CANADA_EXAMPLE = (<<-CSV).strip
Expand Down