Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add winget #656

Closed
wants to merge 1 commit into from
Closed

Add winget #656

wants to merge 1 commit into from

Conversation

starscouts
Copy link

@starscouts starscouts commented Jul 29, 2021

I added the winget package manager, that will be preinstalled on Windows 11, after mentioning Chocolatey.

@canton7
Copy link
Owner

canton7 commented Jul 29, 2021

Interesting. I don't know how comfortable I am linking to a package which someone else controls: I've got no guarantee that the winget package isn't malicious, and is up to date.

@starscouts
Copy link
Author

Interesting. I don't know how comfortable I am linking to a package which someone else controls: I've got no guarantee that the winget package isn't malicious, and is up to date.

If I understand correctly how it works, winget directly fetches the package from GitHub:
image

@canton7
Copy link
Owner

canton7 commented Jul 29, 2021

Right, but it uses a manifest which was submitted and updated by a wide range of people. I've no idea why that last one changed the version from 1.1.28 (correct) to 1.1.28.0 (incorrect).

I don't know if there's any way of integrating winget into my CI process, so I can automatically submit updates...

@canton7
Copy link
Owner

canton7 commented Jul 29, 2021

I'm going to mull this over for a bit I think, before recommending it.

Thanks for pointing it out!

@quhxl
Copy link

quhxl commented Aug 16, 2021

We have no control over the version number, as it must match the entry in the Add/Remove list in the control panel. Each package is scanned with VirusTotal, goes through automatic validation and is manually checked by a moderator team before being accepted. Hopefully this clears up some questions.

@BraINstinct0
Copy link

Testing out a possible solution: use github action to create(by wingetcreate) and submit.
If successful or get useful insights on this I'll do a PR.(no ETA for now)

@BraINstinct0
Copy link

Reporting back: the blocking issue is, the current maifest done by @quhxl only has the x64 version. That's not problematic for x64; but since Winget and SyncTrayzor are both available for x86 this is not anticipated.
If you feel OK, I'll make a PR to edit @quhxl 's 1.1.29.0 to support both architecture first,
then make a Github Action integration PR here.

@BraINstinct0
Copy link

BraINstinct0 commented Nov 24, 2021

Summary: has issues to solve, but automation is clearly possible.
There's two or three options:

  1. Only push Release to Winget whenever a new release is made
  2. Push both Release and Prerelease to Winget
  3. Push Release to SyncTrayzor.SyncTrayzor, and push PreRelease to SyncTrayzor.SyncTrayzorBeta.
    Which would you prefer @canton7 ?

Edit: expect a week or more for my next reply(possibly)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants