Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance examples for Collections methods. #1726

Merged
merged 3 commits into from Aug 5, 2021

Conversation

romanbalayan
Copy link
Contributor

@romanbalayan romanbalayan commented Oct 5, 2020

Partial documentation update for #1609

Updated collections method examples, including usage for callbacks, promises and async/await

@aearly
Copy link
Collaborator

@aearly aearly commented Oct 17, 2020

Hi, thanks for this, these are really excellent examples!

I agree with @caub in #1609 -- the promise examples aren't that useful -- I think we should just have callback style, and async/await style, and also examples that use async iteration functions.

@gkatsanos
Copy link

@gkatsanos gkatsanos commented Nov 19, 2020

Given the work @romanbalayan did for this, isnt' there a possibility to merge the PR even partially? It's a pity when contributors come with work and are said "well this is excellent but pretty much rewrite it". ?

@aearly aearly merged commit 159a119 into caolan:master Aug 5, 2021
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants