Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement style guide check via jscs #837

Merged
merged 2 commits into from
Jul 9, 2015
Merged

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jul 3, 2015

Wheewh 😩 I need β˜•

Stricter rules (e.g. google or airbnb style guide) should probably follow

@aearly
Copy link
Collaborator

aearly commented Jul 3, 2015

I'm πŸ‘ for standardizing on indentation, but πŸ‘Ž for the other stuff. I don't really care about whether function should have a following space or single vs. double quotes. Can you make the .jscsrc unopinionated about that kind of stuff?

@megawac
Copy link
Collaborator Author

megawac commented Jul 3, 2015

You can, I just had it generate this change set using googles style guide preset rules and then disabled the presets. I do think its good to follow a consistent style for most of this stuff, especially in small, heavily used code bases.

@megawac
Copy link
Collaborator Author

megawac commented Jul 4, 2015

Btw it's jscs <file> --fix to auto correct the formatting

On Fri, Jul 3, 2015 at 6:17 PM, Alexander Early notifications@github.com
wrote:

I'm [image: πŸ‘] for standardizing on indentation, but [image: πŸ‘Ž] for
the other stuff. I don't really care about whether function should have a
following space or single vs. double quotes. Can you make the .jscsrc
unopinionated about that kind of stuff?

β€”
Reply to this email directly or view it on GitHub
#837 (comment).

megawac added a commit that referenced this pull request Jul 9, 2015
Implement style guide check via jscs
@megawac megawac merged commit 7ea45d7 into caolan:master Jul 9, 2015
@megawac
Copy link
Collaborator Author

megawac commented Jul 9, 2015

I'd still like to enforce slightly stricter style in the future

@aearly
Copy link
Collaborator

aearly commented Jul 9, 2015

What value does a stricter style bring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants