Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor queue to make it easier to customize behavior #950

Closed
wants to merge 1 commit into from

Conversation

adam-26
Copy link
Contributor

@adam-26 adam-26 commented Oct 29, 2015

Refer to issue #947.

For an example usage, I have created a 'topical queue', where each queue item is assigned a topic. Each topic can be paused/resumed without impacting other topics. See here: adam-26@6ba827d

@aearly
Copy link
Collaborator

aearly commented Jan 7, 2016

I like that this simplifies the implementation of queue a bit, but I don't really like how it exposes some of the private internals (e.g. q._getTasksToProcess). If we expose them, we'll need tests for them, and should make them public. Otherwise, if we refactor the queue some more (which is likely), we'll inadvertently break people's code.

@aearly aearly closed this Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants